Use toArray instead of each to fix reordering bug

voltrevo · Sep 22, 2015 · 5671a43 · 5671a43
1 parent 339bbea
commit 5671a43
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/lib/Collection.js b/lib/Collection.js
@@ -18,15 +18,13 @@ module.exports = function() {
     };
   };
 
-  collection.each = function(fn) {
-    var currElements = elements;
-    elements = [];
-
-    currElements.forEach(function(el) {
-      if (el.value) {
-        elements.push(el);
-        fn(el.value);
-      }
+  collection.toArray = function(fn) {
+    elements = elements.filter(function(element) {
+      return element.value !== undefined;
+    });
+
+    return elements.map(function(element) {
+      return element.value;
     });
   };
 

diff --git a/lib/index.js b/lib/index.js
@@ -25,7 +25,7 @@ module.exports = function(asyncParam) {
 
   eventEmitter.emit = function(evt, value) {
     async(function() {
-      events.get(evt).each(function(handler) {
+      events.get(evt).toArray().forEach(function(handler) {
         handler(value);
       });
     });