Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library just spins (Loading) #81

Open
holiman opened this issue Oct 17, 2015 · 3 comments
Open

Library just spins (Loading) #81

holiman opened this issue Oct 17, 2015 · 3 comments

Comments

@holiman
Copy link

holiman commented Oct 17, 2015

When I go to the library view, it just spins (Loading). Howver, if I manually via the console call loadLibraryIfNeeded(), it loads just fine. I can't see that loadLibraryIfNeeded() is called from anywhere in the source code, and I don't know where it's intended to be called from.

root@volumio:/var/www# grep -r "loadLibraryIfNeeded" 
js/volumio.library.js:function loadLibraryIfNeeded() {
@reallyNotAName
Copy link

This likely is not the ideal solution, but adding the callback to the last line of the script volumio.library.js worked for me.
So the last end of the script looks like:
// Resize event
$(window).resize(function() {
decideViewLayout();
});
loadLibraryIfNeeded();
});

@volumio
Copy link
Owner

volumio commented Nov 17, 2015

Thank you for reporting. But all development efforts are now focused on Volumio2:
https://github.com/volumio/Volumio2

@kdeenkhoorn
Copy link

In my humble opinion is should be placed at the point where the library is enabled.

// Tabs initialization
if (library.isEnabled) {
enableLibrary();
loadLibraryIfNeeded();
} else {
disableLibrary();
}

Seems logic to me, if the library is enabled within the settings menu the library has to be loaded.
If not enabled don't bother.

Possibly it should even be the final part of the 'enableLibrary();' function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants