Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "path" variable for mounts #11

Merged
merged 1 commit into from
Jan 15, 2016

Conversation

mpasteur
Copy link
Contributor

@mpasteur mpasteur commented Jan 9, 2016

@volumio
Copy link
Owner

volumio commented Jan 14, 2016

I tested it and noticed a pair of things, otherwise is perfect, good work!

As you can see from the screenshot:

image

  • I would remove the path column, instead just add the name before and the path after, like:

Flac on 192.168.1.142/Flac
Mymusic on 192.168.1.142/music

  • Second thing, I see that name is still used as both mountpoint and share name. Instead name should be the mountpoint (aka the name we see while browsing), while the path should be the share + deeper folders. What do you think?

After those are fixed we can happily merge!

@mpasteur
Copy link
Contributor Author

The screenshot is what you get?
You should have something like :
Name | Path
Flac | 192.168.1.142/Flac
My music | 192.168.1.142/music

I maybe missed to commit some files...

But I get your point so if you want I can easily remove this Path column.

For the second point I don't know if I really understood...
IHMO The name should be used for browsing as it's the mount point (the share named Mymusic is mounted on /mnt/Mymusic) but the path is only used on fstab to configure the mount /mnt/Mymusic - > 192.168.1.142/music

@volumio
Copy link
Owner

volumio commented Jan 14, 2016

Yes on the second point we're saying the same thing, except that now is not the case...
Also, when failing to mount there are no errors reported...

@mpasteur
Copy link
Contributor Author

OK I'll check tonight... Should we create a thread on the dev forum to
track this?

Le jeu. 14 janv. 2016 13:37, Volumio notifications@github.com a écrit :

Yes on the second point we're saying the same thing, except that now is
not the case...
Also, when failing to mount there are no errors reported...


Reply to this email directly or view it on GitHub
#11 (comment).

@volumio
Copy link
Owner

volumio commented Jan 14, 2016

Yes that's a good idea... Also for collecting suggestions on this part
https://volumio.org/forum/volumio2-nas-configuration-suggestions-and-developments-t3827.html

volumio added a commit that referenced this pull request Jan 15, 2016
@volumio volumio merged commit 5e88626 into volumio:master Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants