New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.2.2 Mother Earth Radio #275
Conversation
i hope new version with correct package-lock.json is a easy solution. |
I can see now the v1.2.2 in beta status, I'll give it a try so it can be eventually promoted to stable |
it looks perfect to me, the new jazz channel is awesome! @balbuze according to me it can be promoted to stable and released for all the variants |
Sure! Tonight! |
@balbuze - being an amateur, so i might be wrong, yet i think the plugin helper could be updated to using "npm ci" instead of "npm install" because only "npm ci" did update package-lock.json for me. Maybe you want to investigate. |
Please, remove zip file. We need just source code. No node_modules for GitHub PR.
Node_modules are generated using package.json |
naming fixed, deleted zip file, node-modules are not included, i got the procedure wrong one time because the "volumio plugin submit" got stuck on "stage changes.." part - my mistake, apologies.
hope issues are solved now |
previous 1.2.1 commit did not show up in the Plugins Store, this pull request updates the package-lock.json.
npm did not update package-lock.json to 1.2.1 itself, maybe that is a problem for the plugin store.