Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2.2 Mother Earth Radio #275

Merged
merged 10 commits into from Nov 8, 2023
Merged

v1.2.2 Mother Earth Radio #275

merged 10 commits into from Nov 8, 2023

Conversation

FlorianReiterer
Copy link
Contributor

previous 1.2.1 commit did not show up in the Plugins Store, this pull request updates the package-lock.json.
npm did not update package-lock.json to 1.2.1 itself, maybe that is a problem for the plugin store.

@FlorianReiterer FlorianReiterer changed the title v1.2.1 Mother Earth Radio (package-lock.json) v1.2.2 Mother Earth Radio Nov 6, 2023
@FlorianReiterer
Copy link
Contributor Author

i hope new version with correct package-lock.json is a easy solution.

@Darmur
Copy link
Contributor

Darmur commented Nov 8, 2023

I can see now the v1.2.2 in beta status, I'll give it a try so it can be eventually promoted to stable

@Darmur
Copy link
Contributor

Darmur commented Nov 8, 2023

it looks perfect to me, the new jazz channel is awesome!

@balbuze according to me it can be promoted to stable and released for all the variants

@balbuze
Copy link
Collaborator

balbuze commented Nov 8, 2023

Sure! Tonight!

@FlorianReiterer
Copy link
Contributor Author

@balbuze - being an amateur, so i might be wrong, yet i think the plugin helper could be updated to using "npm ci" instead of "npm install" because only "npm ci" did update package-lock.json for me. Maybe you want to investigate.

@balbuze
Copy link
Collaborator

balbuze commented Nov 8, 2023

Please, remove zip file. We need just source code. No node_modules for GitHub PR.
Why v1.2.2 instead of 1.2.2? Please correct it.
When you submit to make available as beta, just do

volumio plugin submit

Node_modules are generated using package.json
Thanks

@FlorianReiterer
Copy link
Contributor Author

naming fixed, deleted zip file, node-modules are not included, i got the procedure wrong one time because the "volumio plugin submit" got stuck on "stage changes.." part - my mistake, apologies.
Sorry for the naming i misunderstood a previous comment of yours:

Please submit your plugin v1.2.1

hope issues are solved now

@balbuze balbuze merged commit c1acffe into volumio:master Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants