Adding support for rooms #30
Conversation
| end | ||
|
|
||
| def create_changeset(params) do | ||
| %Room{ } |
There was a problem hiding this comment.
I have questioned whether or not we should do this over the convention that I see where *changeset functions take in the model.
The usual way this is defined is like this:
def create_changeset(model, params) do
model
|> ...
endthat idiom is every I have seen, the default changeset for example is defined with the same parameters. If I had to guess it's for pipelining.
There was a problem hiding this comment.
I should follow the conventions then! I dropped the model parameter because it was a create and I was thinking they shouldn't provide one.
Hey do you remember why we went with a create_changeset? Could most things be handled by a regular changeset function? I know we discussed this and something came up that led to using multiple changeset functions. I'm thinking for Room I might switch this to a single changeset since right now there are no differences in context.
There was a problem hiding this comment.
Ah, yeah we used create_changeset in the User module and that was because it was a bit of an odd case where the password hash was being generated which would not want not want when updating a user etc.
In your case I think changeset would be fine. I think I have used changeset in all the others like the Character module and any of the newer ones added.
Trying to accomplish #26