Skip to content

Commit

Permalink
[lists][builtins] Add FIXME markers for issue #88
Browse files Browse the repository at this point in the history
  • Loading branch information
cipriancraciun committed Jun 6, 2018
1 parent 9456424 commit ad583d0
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions sources/builtins_lists.rs
Original file line number Diff line number Diff line change
Expand Up @@ -393,13 +393,15 @@ pub fn list_make (length : usize, fill : &Value, immutable : Option<bool>) -> (O
#[ cfg_attr ( feature = "vonuvoli_inline", inline ) ]
pub fn list_clone (list : &Value, immutable : Option<bool>) -> (Outcome<Value>) {
TODO! ("optimize the vector allocation");
FIXME! ("if `immutable == None` keep the mutability status of each cloned pair", (github_issue, 88));
let (buffer, last) = try! (vec_list_clone_dotted (list));
succeed! (list_collect_dotted (buffer, last, immutable));
}

#[ cfg_attr ( feature = "vonuvoli_inline", inline ) ]
pub fn list_reverse (list : &Value, immutable : Option<bool>) -> (Outcome<Value>) {
TODO! ("optimize the vector allocation");
FIXME! ("if `immutable == None` keep the mutability status of each cloned pair", (github_issue, 88));
let buffer = try! (vec_list_clone (list));
succeed! (list_collect (buffer.into_iter () .rev (), immutable));
}
Expand Down

0 comments on commit ad583d0

Please sign in to comment.