Remove node-pre-gyp as a bundled dependency and use preinstall script instead

[bminer]

According to the new docs here, it might be considered better practice to add preinstall script npm install node-pre-gyp instead of using the bundledDependencies key. This would allow other NPM modules to re-use the same version of node-pre-gyp, for example.

See the node-pre-gyp Github repo page for more info. This issue might also be relevant: mapbox/node-pre-gyp#162

[reconbot]

If it works it work, I'm for it

[reconbot]

It works, I'll do a patch release in a little bit so you can use it.

[reconbot]

This doesn't work, it's fine when you're installing serialport from a clone, but as a dependency it breaks everything and ends up in an endless loop. I have to revert this change. I've reopened the issue if you want to see if you can give it a go.

[springmeyer]

Sorry you hit problems. As per mapbox/node-pre-gyp#162 (comment) I've ask for help to know how to replicate to dig into this.

This would allow other NPM modules to re-use the same version of node-pre-gyp, for example.

Incorrect. They still will install their own version (unless -g is passed). And this is needed since each module needs node-pre-gyp around before installing to install itself.

[reconbot]

I had this happening using node v4.4.3 (npm v3.8.6) we support node 0.10-5.x so it's bound to be on other platforms too

[springmeyer]

I'm unable to replicate (mapbox/node-pre-gyp#162 (comment)) so I am presuming this is not a widespread problem and rather something specific to your setup.

[reconbot]

It's happening to me on two different computers both with NVM. @bminer do you mind hopping on the mapbox thread and try to reproduce?

[bminer]

Hmm... I can't replicate either... what version of node-serialport exhibits this problem?

And, I'm really confused on what the issue is exactly... you're saying that whenever you NPM install a package that depends on node-serialport, the preinstall script for node-serialport (which simply installs node-pre-gyp) runs in an infinite loop? Also, why is "node-pre-gyp-github" required as a preinstall dep?

Thanks!

[reconbot]

It was a mistake, I've got a branch with the unbundled package.json without pregyp github. https://github.com/voodootikigod/node-serialport/compare/unbundle npm install voodootikigod/node-serialport#unbundle installs it and it's working for me now...

[reconbot]

But not everywhere. I updated the node-pregyp issue with details. mapbox/node-pre-gyp#162 (comment)

[reconbot]

Keeping this link here for our records, npm/npm#12583 is preventing us from doing this

[reconbot]

Or maybe mapbox/node-pre-gyp#162 (comment)

[reconbot]

@bminer Please test serialport@3.1.2-beta1 I've removed the bundling, I want to make sure it fixes your use case.