Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin loading resets variants #330 #381

Merged

Conversation

otonashixav
Copy link
Contributor

Fixes #330 by spreading the existing variants. Also added a test.

@alexanderniebuhr alexanderniebuhr changed the title Fix issue 330 load plugin resets variants fix: plugin loading resets variants #330 Jul 7, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #381 (f88bf97) into main (728d187) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
+ Coverage   88.14%   88.18%   +0.04%     
==========================================
  Files          56       56              
  Lines        4773     4773              
  Branches     1024     1024              
==========================================
+ Hits         4207     4209       +2     
+ Misses        303      301       -2     
  Partials      263      263              
Impacted Files Coverage Δ
src/lib/index.ts 79.49% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 728d187...f88bf97. Read the comment docs.

@antfu antfu merged commit db1facc into windicss:main Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loadPlugin resets variants to defaults
4 participants