Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add variant for the ::file-selector-button pseudo-element #388

Merged
merged 1 commit into from
Aug 9, 2021
Merged

feat: add variant for the ::file-selector-button pseudo-element #388

merged 1 commit into from
Aug 9, 2021

Conversation

lukewarlow
Copy link
Contributor

@lukewarlow lukewarlow commented Jul 9, 2021

This PR adds a variant for the ::file-selector-button pseudo element.

I think I've added to the relevant tests but feel free to point out any others that are required.

Might be worth adding the prefixed ::-webkit-file-upload-button and maybe even ::-ms-browse to get browser support from 78 to 95+, but I'm not sure how to go about doing that. I can see I maybe need to add a function in the helpers file but not sure where it would be called from?

@codecov-commenter
Copy link

Codecov Report

Merging #388 (755a4f4) into main (728d187) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   88.14%   88.14%           
=======================================
  Files          56       56           
  Lines        4773     4774    +1     
  Branches     1024     1024           
=======================================
+ Hits         4207     4208    +1     
  Misses        303      303           
  Partials      263      263           
Impacted Files Coverage Δ
src/config/order.ts 100.00% <ø> (ø)
src/lib/variants/state.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 728d187...755a4f4. Read the comment docs.

@antfu antfu changed the title Added variant for the ::file-selector-button pseudo-element feat: add variant for the ::file-selector-button pseudo-element Jul 12, 2021
@antfu antfu requested a review from voorjaar July 12, 2021 08:15
@itpropro
Copy link

itpropro commented Aug 5, 2021

@voorjaar or @antfu did you have time to review this? I actually have a use case for the pseudo element and want to avoid pulling windi from a PR branch :)

@antfu antfu merged commit e408af1 into windicss:main Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants