feat: export sky palette in default colors (closes #425) #426
Conversation
high1
changed the title
high1
changed the title
high1
changed the title
- removed lightBlue palette inside colors, since it was deprecated with sky - exported sky and light-blue as an alternative to it inside default colors
|
/lgtm |
- since light-blue was deprecated and is just an alternative for sky now, use colors.sky in test configurations
- do not remove lightBlue completely from colors, since users should still be able to import it directly from colors - instead, reexport sky and show a deprecation warning
|
@alexanderniebuhr The issue could arise if users import lightBlue directly from colors - and the test shows that. Added a deprecation warning and a reexport of the sky pallete for lightBlue. |
Codecov Report
@@ Coverage Diff @@
## main #426 +/- ##
==========================================
- Coverage 88.20% 87.57% -0.64%
==========================================
Files 56 57 +1
Lines 4783 4830 +47
Branches 1029 1036 +7
==========================================
+ Hits 4219 4230 +11
- Misses 301 337 +36
Partials 263 263
Continue to review full report at Codecov.
|
|
@alexanderniebuhr @antfu Is there something wrong with the PR? I see that the coverage has decreased, but I'm not sure how to test code that logs to console, TBH. |
|
@high1 I think it is fine. Please wait patiently for the other maintainers to approve :) |
antfu
changed the title
with sky
colors