Support Rails 4.x and fix generating examples #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test::Unit is not bundled since CRuby 2.2.0 but ActiveSupport 3.2.x requires it for ActiveSupport::TestCase.
It changes for ruby's version.
ActiveSupport::TestCase is built on Test::Unit in 3.2, but on minitest in 4.0 or higher.
Since Rails 4.1.x, a HABTM association defines intermediate classes.
| has_many :subscribed_gems, :through => :subscriptions, | ||
| :source => :rubygem, | ||
| :order => "name ASC" | ||
| end |
There was a problem hiding this comment.
This is the sort of version switching I was dreading having to do... well done, thank you :)
|
This is fabulous thank you! ❤️ |
|
In this case, yes please :) |
a2ikm
force-pushed
the
support_rails_4.x
branch
from
6e3fd70
to
1fd49c6
Compare
|
I squashed commits. |
kerrizor
added a commit
that referenced
this pull request
Feb 12, 2015
Support Rails 4.x and fix generating examples
|
Looks good from here! Merging and will cut a new release shortly. Thanks again for the hard work here! |
This was referenced Feb 12, 2015
|
Thank you for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tweaked tests around
setupandteardown, but not changed essentially.I removed Gemfile.lock from repository because it can change for ActiveSupport's dependency on Test::Unit or minitest and CRuby's version. But it doesn't make any wrong effects on developing and releasing.