Fix only_recursion_depth option failure when used from rake erd task #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the value of only_recursion_depth is converted to a symbol. This then fails to convert to an integer in RailsERD::diagram.generate. This change fixes the issue by converting the option value to an int if it only contains digits.
|
This looks ok; is there a test we could add to ensure we don't regress? |
…symbols. In a similar way to the current tests that verify boolean values are set in the model as booleans, this asserts that a string of only digits will be set in the model as the integer value rather than a symbol.
|
@kerrizor - I added that test to hopefully avoid regressing. Let me know if there's more you'd like adding to this. |
|
Thank you for your patience.. this gets into the issue around the CLI/rake logic split that we need to undo (#289) but I'm tagging this for v1.6 release |
|
Closing in favor of a rebased version in #324 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the value of only_recursion_depth is converted to a symbol.
This then fails to convert to an integer in RailsERD::diagram.generate.
This change fixes the issue by converting the option value to an int if
it only contains digits.