Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle paper_trail's custom version classes. #304

Closed
wants to merge 3 commits into from

Conversation

inclooder
Copy link
Contributor

@inclooder inclooder commented Sep 25, 2018

Fix for #303
Handle paper_trail's custom version classes.

@kerrizor
Copy link
Collaborator

Hi, and thanks for the PR! Apologies on not responding sooner; my workflow for being notified of new issues broke such that I received some notifications, but not all, and unfortunately yours was one I missed.

If you have the time, could you rebase and resubmit? I recently merged fixes for minitest that may help clear up your test failures.

@inclooder
Copy link
Contributor Author

@kerrizor thank you for your time. I've rebased the branch but the master is failing so this one will fail too :(

@kerrizor
Copy link
Collaborator

@inclooder Hmmm.. looks like an apt-get hiccup on Travis.. I've rerun the build for and it does show green now.

@kerrizor kerrizor changed the title Fix for #303 Handle paper_trail's custom version classes. May 11, 2019
@kerrizor
Copy link
Collaborator

@inclooder I had so many things to do with rebasing and merging that I went ahead and opened a new branch for this PR at #325 (don't worry, you'll still get credit! 😉) Thanks again for your contribution and your patience!

@kerrizor kerrizor closed this May 12, 2019
kerrizor added a commit that referenced this pull request May 12, 2019
Rebase of #304 - Handle paper_trail's custom version classes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants