Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for adding require false option in Gemfile #339

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kikunantoka
Copy link
Contributor

@kikunantoka kikunantoka commented Jul 30, 2019

Why

Related Issue

#282

Related PR

#295

Cause

When I added require false option in Gemfile and added requirement in generated lib/auto_generate_diagram.rake file, I encountered errors as followings.

Don't know how to build task 'erd' (See the list of available tasks with `rails --tasks`)

I think loading is only /tasks/**/*.rake file as followings.

Dir[File.join(File.dirname(__FILE__), 'tasks', '**/*.rake')].each { |rake| load rake }

It doesn't include raile_erd/tasks.rake file.
So, Rake::Task["erd"] is not loaded.

What did I do

  • Rename(Replace) rails_erd/tasks.rake to tasks/erd.rake
  • Fix template for adding requirement.
  • Fix README for adding require false option.

Copy link
Contributor

@mathieujobin mathieujobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this

@kikunantoka
Copy link
Contributor Author

Thank you for your reviewing.

@n-rodriguez
Copy link
Contributor

Hi there! Any news?

@kerrizor
Copy link
Collaborator

If we can get this rebased and the conflicts resolved, I'm happy to merge - @ me

@n-rodriguez
Copy link
Contributor

ping @kikunantoka :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants