Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkResult() should be optional #45

Closed
vorburger opened this issue Nov 15, 2020 · 2 comments
Closed

checkResult() should be optional #45

vorburger opened this issue Nov 15, 2020 · 2 comments

Comments

@vorburger
Copy link
Owner

The waitForExit() methods currently internally (all?) use checkResult().

This makes it impossible to wait for a non-sucessful exit - which could be handy for some use cases (e.g. a CLI testing tool).

@mihneagiurgea
Copy link

mihneagiurgea commented Dec 7, 2020

I think this is potentially related: #47

@vorburger
Copy link
Owner Author

@mihneagiurgea your #47 is a "bug" where an external process which is expected to exit with 0 (mysqld) is handled wrong. I suspect #96 actually fixed that problem.

This issue however is an "enhancement" to make this library usable to exec something which one is expecting (!) to have a non-zero exit code. One example of this is my use of this library for the Executable Markdown of Enola.dev, notably to avoid this (very) ugly initial workwaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants