volatile isAlive (fixes #99) #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vorburger
approved these changes
Apr 17, 2023
This was referenced Apr 17, 2023
Closed
vorburger
added a commit
to MariaDB4j/MariaDB4j
that referenced
this pull request
Apr 17, 2023
vorburger
added a commit
to MariaDB4j/MariaDB4j
that referenced
this pull request
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There's a potential thread safety violation where different threads could be reading and writing to the
isAlivefield without synchronization. See #99Solution
It seems like it's safe to race on isAlive, so we don't necessarily need to add synchronization. Instead, we will continue to permit racing on isAlive but will ensure that publication is safe by marking it as volatile.
Result
Publication will always happen. This should hopefully unblock #96.