Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: add the new keys values down the tree #84

Closed
zakidze opened this issue Jun 20, 2024 · 19 comments
Closed

feature request: add the new keys values down the tree #84

zakidze opened this issue Jun 20, 2024 · 19 comments

Comments

@zakidze
Copy link

zakidze commented Jun 20, 2024

example when i have a json with missing value in certain locale and i use inio to add the missing value

inio adds the missing value + key to the end

reason : when use gitadd and commit only new keys would be shown or added stuff

@vordgi
Copy link
Owner

vordgi commented Jun 20, 2024

What if u had:

{
  "example": {
    "key1": "value1"
  },
  "example2": {
    "key2": "value2"
  }
}

And add new key "example.key3"?

And git should always show changes only, no matter where they are

@zakidze
Copy link
Author

zakidze commented Jun 20, 2024

i see that git example delete everything than add everything

@zakidze
Copy link
Author

zakidze commented Jun 20, 2024

Screenshot_20240620_180844_Chrome

Screenshot_20240620_180834_Chrome

@zakidze
Copy link
Author

zakidze commented Jun 20, 2024

look even if 1 line is change git delete everything and adds everything

@zakidze
Copy link
Author

zakidze commented Jun 20, 2024

this make the review hard to get the changes

@vordgi
Copy link
Owner

vordgi commented Jun 20, 2024

There were 2 spaces, but after inio there 1 tab?

Do u use prettier or something like that?

@zakidze
Copy link
Author

zakidze commented Jun 20, 2024 via email

@zakidze
Copy link
Author

zakidze commented Jun 20, 2024

i use prettier

@vordgi
Copy link
Owner

vordgi commented Jun 20, 2024

The problem is that sometimes it format your code, sometimes its not. You can use husky and format it each time on precommit.

From my side I will think about inio format style

@zakidze
Copy link
Author

zakidze commented Jun 20, 2024

so there is some incostincies between inio styles and inio styles

@vordgi
Copy link
Owner

vordgi commented Jun 20, 2024

Between inio formatting and prettier formatting*

And it is logical. Inio have no idea about your formatters and linters (and shouln't)

@zakidze
Copy link
Author

zakidze commented Jun 20, 2024

whar you propose souloution for this

@vordgi
Copy link
Owner

vordgi commented Jun 20, 2024

For now - "You can use husky and format it each time on precommit" [by prettier to keep the same codestyle which declared in prettier rules]

But I will think in additional

@vordgi
Copy link
Owner

vordgi commented Jun 30, 2024

Closing this task because the problem is not in this (and this cannot be done for reasons described above).

Opened a task on indent style rules - #98

@vordgi vordgi closed this as completed Jun 30, 2024
@zakidze
Copy link
Author

zakidze commented Jun 30, 2024

you know better

PS: the adviece you told me about worked well i mean husky with prettier formating

at least reduced 6000 lines to 600 lines

@zakidze
Copy link
Author

zakidze commented Jun 30, 2024

hope you tackle the search missing value on all project issue or , repititive keys issue

@vordgi
Copy link
Owner

vordgi commented Jun 30, 2024

I keep them in mind, looking for a suitable solution

@zakidze
Copy link
Author

zakidze commented Jun 30, 2024 via email

@vordgi
Copy link
Owner

vordgi commented Jun 30, 2024

Indent rules shipped. Configure it just like your prettier rules.

inio.config.js

module.exports = {
    indent: {
        size: 1,
        type: "tab",
    },
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants