Build fixes #1
Merged
Build fixes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the build with autoreocnf-2.71.
Silences trivial non-fatal errors during make
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
May 13, 2022
Fixing the autoreconf somehow fixed the build with slibtool. Upstream-PR: voretaq7/radmind#1 Upstream-PR: Radmind/radmind#336 Upstream-PR: https://sourceforge.net/p/libsnet/patches/4/ Bug: https://bugs.gentoo.org/779664 Signed-off-by: orbea <orbea@riseup.net>
The legacy macros CHECK_ZLIB and CHECK_SSL add many instances of hardcoded -L/usr/lib which is problematic on newer systems. It is better to use pkg-config so they are always found where expected. Also removed some totally broken legacy osx macros.
|
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
May 13, 2022
The build prepends ../ to the $(LIBTOO) variable which obviously doesn't work with slibtool. Additionally the build has a lot of other autoreconf issues that needed to be fixed. Upstream-PR: voretaq7/radmind#1 Upstream-PR: Radmind/radmind#336 Upstream-PR: https://sourceforge.net/p/libsnet/patches/4/ Upstream-PR: https://sourceforge.net/p/libsnet/patches/6/ Bug: https://bugs.gentoo.org/779664 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
May 13, 2022
The build prepends ../ to the $(LIBTOOL) variable which obviously doesn't work with slibtool. Additionally the build has a lot of other autoreconf issues that needed to be fixed. Upstream-PR: voretaq7/radmind#1 Upstream-PR: Radmind/radmind#336 Upstream-PR: https://sourceforge.net/p/libsnet/patches/4/ Upstream-PR: https://sourceforge.net/p/libsnet/patches/6/ Bug: https://bugs.gentoo.org/779664 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
May 13, 2022
The build prepends ../ to the $(LIBTOOL) variable which obviously doesn't work with slibtool. Additionally the build has a lot of other autoreconf issues that needed to be fixed. Upstream-PR: voretaq7/radmind#1 Upstream-PR: Radmind/radmind#336 Upstream-PR: https://sourceforge.net/p/libsnet/patches/4/ Upstream-PR: https://sourceforge.net/p/libsnet/patches/6/ Bug: https://bugs.gentoo.org/779664 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
May 13, 2022
The build prepends ../ to the $(LIBTOOL) variable which obviously doesn't work with slibtool. Additionally the build has a lot of other autoreconf issues that needed to be fixed. Upstream-PR: voretaq7/radmind#1 Upstream-PR: Radmind/radmind#336 Upstream-PR: https://sourceforge.net/p/libsnet/patches/4/ Upstream-PR: https://sourceforge.net/p/libsnet/patches/6/ Bug: https://bugs.gentoo.org/779664 Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
May 13, 2022
The build prepends ../ to the $(LIBTOOL) variable which obviously doesn't work with slibtool. Additionally the build has a lot of other autoreconf issues that needed to be fixed. Upstream-PR: voretaq7/radmind#1 Upstream-PR: Radmind/radmind#336 Upstream-PR: https://sourceforge.net/p/libsnet/patches/4/ Upstream-PR: https://sourceforge.net/p/libsnet/patches/6/ Bug: https://bugs.gentoo.org/779664 Signed-off-by: orbea <orbea@riseup.net>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
May 13, 2022
The build prepends ../ to the $(LIBTOOL) variable which obviously doesn't work with slibtool. Additionally the build has a lot of other autoreconf issues that needed to be fixed. Upstream-PR: voretaq7/radmind#1 Upstream-PR: Radmind/radmind#336 Upstream-PR: https://sourceforge.net/p/libsnet/patches/4/ Upstream-PR: https://sourceforge.net/p/libsnet/patches/6/ Bug: https://bugs.gentoo.org/779664 Signed-off-by: orbea <orbea@riseup.net> Closes: #25459 Signed-off-by: Sam James <sam@gentoo.org>
This was previously set in aclocal.m4
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
May 14, 2022
When radmind is build while crypto-sasl is installed on the system the libsnet submodule will enable it and then radmind will fail to compile with undefined refererenes for sasl. This was caused by my earlier patches that accidentally dropped that part in radmind that disabled sasl support during the libsnet configure process. I also added missing dependencies and USE flags. Bug: https://bugs.gentoo.org/844160 Upstream-PR: Radmind/radmind#336 Upstream-PR: voretaq7/radmind#1 Upstream-PR: https://sourceforge.net/p/libsnet/patches/7/ Fixes: gentoo@601775b Signed-off-by: orbea <orbea@riseup.net>
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
May 14, 2022
When radmind is build while cyrus-sasl is installed on the system the libsnet submodule will enable it and then radmind will fail to compile with undefined refererenes for sasl. This was caused by my earlier patches that accidentally dropped that part in radmind that disabled sasl support during the libsnet configure process. I also added missing dependencies and USE flags. Bug: https://bugs.gentoo.org/844160 Upstream-PR: Radmind/radmind#336 Upstream-PR: voretaq7/radmind#1 Upstream-PR: https://sourceforge.net/p/libsnet/patches/7/ Fixes: gentoo@601775b Signed-off-by: orbea <orbea@riseup.net>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
May 15, 2022
When radmind is build while cyrus-sasl is installed on the system the libsnet submodule will enable it and then radmind will fail to compile with undefined refererenes for sasl. This was caused by my earlier patches that accidentally dropped that part in radmind that disabled sasl support during the libsnet configure process. I also added missing dependencies and USE flags. Bug: https://bugs.gentoo.org/844160 Upstream-PR: Radmind/radmind#336 Upstream-PR: voretaq7/radmind#1 Upstream-PR: https://sourceforge.net/p/libsnet/patches/7/ Fixes: 601775b Signed-off-by: orbea <orbea@riseup.net> Signed-off-by: Sam James <sam@gentoo.org>
|
I’m appalled it took me so long to merge this in, but I still got it merged in before radmind upstream did so there’s that I guess :-) |
|
@voretaq7 Thanks for the merge, any ideas how to get upstream radmind to review it too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also see: Radmind#336
I am making a PR here too because this is the repo gentoo uses for the source.