Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel 11 support #60

Merged
merged 15 commits into from
Mar 1, 2024
Merged

Add Laravel 11 support #60

merged 15 commits into from
Mar 1, 2024

Conversation

atmonshi
Copy link
Contributor

also I ran the tests all green (3 skipped, 68 passed) :)

@Baspa Baspa self-assigned this Feb 29, 2024
@Baspa
Copy link
Member

Baspa commented Feb 29, 2024

Thanks for your PR! We should probably add separate tests for L11 or change the current workflows because I believe they're written to test Laravel 10 specifically. The tests were running fine locally I assume? @atmonshi

@atmonshi
Copy link
Contributor Author

yes as mentioned :)

also I ran the tests all green (3 skipped, 68 passed) :)

I updated the github action
and some of the dev dependencies
now its support laravel 9,10,11

the plugin: pest-plugin-parallel is now deprecated for pest 2
so not sure how to run it on l9!?

@Baspa
Copy link
Member

Baspa commented Mar 1, 2024

yes as mentioned :)

also I ran the tests all green (3 skipped, 68 passed) :)

I updated the github action and some of the dev dependencies now its support laravel 9,10,11

the plugin: pest-plugin-parallel is now deprecated for pest 2 so not sure how to run it on l9!?

Seems like the Github actions need a PHP upgrade as well. The actions are still failing.

@atmonshi
Copy link
Contributor Author

atmonshi commented Mar 1, 2024

php 8,2 already there not sure why it falling
I added the php to include section let see...

@atmonshi
Copy link
Contributor Author

atmonshi commented Mar 1, 2024

for some reasons my commits not showing in this PR :)

@Baspa
Copy link
Member

Baspa commented Mar 1, 2024

for some reasons my commits not showing in this PR :)

Hmm weird, maybe that's because @markvaneijk made some changes but did not pull yours?

@atmonshi
Copy link
Contributor Author

atmonshi commented Mar 1, 2024

Screenshot 2024-03-01 at 6 26 41 PM

and I see this now when I click on his commit:
"This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository."

but I managed to pull his changes locally and push
but all my commits after that not showing here
github is confusing and acting out sometimes :)

@markvaneijk
Copy link
Member

GitHub acts weird with files in .github, because I only changed code inside this PR, trying to fix the php version mismatch

@atmonshi
Copy link
Contributor Author

atmonshi commented Mar 1, 2024

Github feels a bit protective about .github 😂

I see all the tests are passing finally, thank you all

@markvaneijk
Copy link
Member

Unfortunately it doesn't want to run the actions with the tests in it:

CleanShot 2024-03-01 at 17 17 17@2x

@atmonshi
Copy link
Contributor Author

atmonshi commented Mar 1, 2024

ah spoke too soon..
testing: remove the php from include.
let see if it fails normally!

@atmonshi
Copy link
Contributor Author

atmonshi commented Mar 1, 2024

finally got it all green here

@Baspa
Copy link
Member

Baspa commented Mar 1, 2024

Checks looking good now here as well. Thanks @atmonshi

@Baspa Baspa self-requested a review March 1, 2024 18:40
@Baspa Baspa changed the title add Laravel 11 support Add Laravel 11 support Mar 1, 2024
@Baspa Baspa merged commit 847ca2a into vormkracht10:main Mar 1, 2024
14 checks passed
@atmonshi atmonshi deleted the laravel-11 branch March 1, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants