Skip to content

Commit

Permalink
Document the bug in two-layer option
Browse files Browse the repository at this point in the history
  • Loading branch information
@vorner
vorner committed Dec 26, 2022
1 parent 81a56de commit 41e7e7d
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/lib.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,12 @@ where
/// assert_eq!(0, **arc_swap.load());
/// ```
///
/// # Known bugs
///
/// Currently, things like `ArcSwapAny<Option<Option<Arc<_>>>>` (notice the double Option) don't
/// work properly. A proper solution is being looked into
/// ([#81](https://github.com/vorner/arc-swap/issues)).
///
/// [`Arc`]: https://doc.rust-lang.org/std/sync/struct.Arc.html
/// [`from`]: https://doc.rust-lang.org/nightly/std/convert/trait.From.html#tymethod.from
/// [`RefCnt`]: trait.RefCnt.html
Expand Down

2 comments on commit 41e7e7d

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Track benchmarks

Benchmark suite Current: 41e7e7d Previous: 81a56de Ratio
uncontended/load 17 ns/iter (± 0) 18 ns/iter (± 0) 0.94
uncontended/load_full 28 ns/iter (± 0) 32 ns/iter (± 0) 0.88
uncontended/load_many 49 ns/iter (± 0) 51 ns/iter (± 0) 0.96
uncontended/store 140 ns/iter (± 1) 158 ns/iter (± 0) 0.89
uncontended/cache 1 ns/iter (± 0) 0 ns/iter (± 0) Infinity
concurrent_loads/load 32 ns/iter (± 10) 30 ns/iter (± 14) 1.07
concurrent_loads/load_full 32 ns/iter (± 13) 43 ns/iter (± 15) 0.74
concurrent_loads/load_many 78 ns/iter (± 23) 51 ns/iter (± 29) 1.53
concurrent_loads/store 1499 ns/iter (± 1350) 1464 ns/iter (± 448) 1.02
concurrent_loads/cache 1 ns/iter (± 0) 0 ns/iter (± 0) Infinity
concurrent_store/load 76 ns/iter (± 2) 51 ns/iter (± 2) 1.49
concurrent_store/load_full 129 ns/iter (± 9) 89 ns/iter (± 13) 1.45
concurrent_store/load_many 169 ns/iter (± 5) 134 ns/iter (± 1) 1.26
concurrent_store/store 1005 ns/iter (± 42) 1515 ns/iter (± 33) 0.66
concurrent_store/cache 1 ns/iter (± 0) 1 ns/iter (± 0) 1

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Track benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: 41e7e7d Previous: 81a56de Ratio
uncontended/cache 1 ns/iter (± 0) 0 ns/iter (± 0) Infinity
concurrent_loads/load_many 78 ns/iter (± 23) 51 ns/iter (± 29) 1.53
concurrent_loads/cache 1 ns/iter (± 0) 0 ns/iter (± 0) Infinity

This comment was automatically generated by workflow using github-action-benchmark.

CC: @vorner

Please sign in to comment.