Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for VanishBridge. Raised the target Java version from 11 to 17. #27

Merged
merged 1 commit into from Oct 31, 2023
Merged

Added support for VanishBridge. Raised the target Java version from 11 to 17. #27

merged 1 commit into from Oct 31, 2023

Conversation

Loapu
Copy link
Contributor

@Loapu Loapu commented Oct 25, 2023

I tested the changes myself and it worked, but we all know how things behave in the wild so I'm up for some more testing.

@Loapu Loapu mentioned this pull request Oct 25, 2023
@voruti voruti linked an issue Oct 30, 2023 that may be closed by this pull request
@voruti
Copy link
Owner

voruti commented Oct 30, 2023

To test this, I used the plugin HideMe that I found on Modrinth. I wasn't able to get this to run. I also tried VelocityVanish - with the same result.

Which vanishing plugin are you using on Paper?

@Loapu
Copy link
Contributor Author

Loapu commented Oct 31, 2023

Hello, I used PremiumVanish but SuperVanish would also work. They introduce custom metadata to a vanished player that my bridge queries. VelocityVanish claims to be compatible so it should at least use the same metadata key.

@voruti
Copy link
Owner

voruti commented Oct 31, 2023

I'm not able to get this to work 😅

@voruti
Copy link
Owner

voruti commented Oct 31, 2023

Okay, found the problem. Apparently this only works when IP forwarding is enabled.

@voruti voruti merged commit 12eb28a into voruti:main Oct 31, 2023
@Loapu Loapu deleted the feature/IntegrateVanishBridge branch November 2, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hiding vanished players
2 participants