Add metadata #14
Merged
Add metadata #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voruti
approved these changes
Sep 25, 2021
src/test/resources/openhab2_multipleChannelsOneItem.Metadata.json
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably not perfect but it worked for me with my 370 items and 57 bits of metadata. Your code did a grand job of converting them all plus the channel links - thanks!
Main thing that's missing from this PR is metadata attributes - they will be ignored - I don't have any in my setup so didn't need to code for them. Also wasn't sure of the name of the Metadata json file under OH3 as I currently run OH2 but I guessed it based on the other filenames - see Constants.java.