Authorization Manager Thruway v.4 Compatibility Updates (#33)

* Compat with Thruway 0.4 * Update doc with the Authorization Manager module
voryx · Apr 10, 2017 · f3451c6 · f3451c6
1 parent a6310da
commit f3451c6
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 26 deletions.
diff --git a/README.md b/README.md
@@ -107,40 +107,67 @@ The WAMP-CRA service is already configured, we just need to add a tag to it to h
 
 You can set your own Authorization Manager in order to check if a user (identified by its authid) is allowed to publish | subscribe | call | register
 
-Create your Authorization Manager service, implementing AuthorizationManagerInterface (see the Thruway doc for details)
+Create your Authorization Manager service, extending RouterModuleClient and implementing RealmModuleInterface (see the Thruway doc for details)
 
 ```php
 // src/ACME/AppBundle/Security/MyAuthorizationManager.php
 
 
-use Thruway\Authentication\AuthorizationManagerInterface;
-use Thruway\Message\ActionMessageInterface;
-use Thruway\Message\SubscribeMessage;
-use Thruway\Session;
+use Thruway\Event\MessageEvent;
+use Thruway\Event\NewRealmEvent;
+use Thruway\Module\RealmModuleInterface;
+use Thruway\Module\RouterModuleClient;
 
-class MyAuthorizationManager implements AuthorizationManagerInterface
+class MyAuthorizationManager extends RouterModuleClient implements RealmModuleInterface
 {
-    public function isAuthorizedTo(Session $session, ActionMessageInterface $actionMsg)
+    /**
+     * Listen for Router events.
+     * Required to add the authorization module to the realm
+     *
+     * @return array
+     */
+    public static function getSubscribedEvents()
     {
-        // set here the type of Action you want to check
-        // Here it's only Subscribe
-        if ($actionMsg instanceof  SubscribeMessage) {
-            // Here your own auth rule
-            $topic = $actionMsg->getTopicName();
-            /* In this example sub patterns meet the following :
-             * {userID}.{name}
-             * we explode the topic name to get the userID
-             */
-             $topic = explode('.', $topic);
-            if(is_integer($topic[0])){
-                  // UserID shall meet AuthID, else deny access
-                  if($topic[0] != $session->getMetaInfo()["authid"]){
-                        return false;
-                  }
-            }
+        return [
+            'new_realm' => ['handleNewRealm', 10]
+        ];
+    }
+
+    /**
+     * @param NewRealmEvent $newRealmEvent
+     */
+    public function handleNewRealm(NewRealmEvent $newRealmEvent)
+    {
+        $realm = $newRealmEvent->realm;
+
+        if ($realm->getRealmName() === $this->getRealm()) {
+            $realm->addModule($this);
+        }
+    }
+
+    /**
+     * @return array
+     */
+    public function getSubscribedRealmEvents()
+    {
+        return [
+            'PublishMessageEvent'   => ['authorize', 100],
+            'SubscribeMessageEvent' => ['authorize', 100],
+            'RegisterMessageEvent'  => ['authorize', 100],
+            'CallMessageEvent'      => ['authorize', 100],
+        ];
+    }
 
+    /**
+     * @param MessageEvent $msg
+     * @return bool
+     */
+    public function authorize(MessageEvent $msg)
+    {
+        if ($msg->session->getAuthenticationDetails()->getAuthId() === 'username') {
+            return true;
         }
-        return true;
+        return false;
     }
 }
 ```

diff --git a/src/Voryx/ThruwayBundle/DependencyInjection/VoryxThruwayExtension.php b/src/Voryx/ThruwayBundle/DependencyInjection/VoryxThruwayExtension.php
@@ -93,11 +93,11 @@ protected function configureOptions(&$config, ContainerBuilder $container)
               ->addMethodCall('registerModule', [new Reference('voryx.thruway.authentication.manager')]);
         }
 
-		
+
         if (isset($config['router']['authorization']) && $config['router']['authorization'] !== false) {
             $authId = $config['router']['authorization'];
             $container->getDefinition('voryx.thruway.server')
-                ->addMethodCall('setAuthorizationManager', [new Reference($authId)]);
+                ->addMethodCall('registerModule', [new Reference($authId)]);
         }
 
         if ($container->hasDefinition('security.user.provider.concrete.in_memory')) {