Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set HttpContext.TraceIdentifier value to request trace id #4

Closed
wants to merge 1 commit into from

Conversation

koheatel
Copy link
Member

TracingMiddleware now sets HttpContext.TraceIdentifier value to current request's trace id.

@kunga
Copy link
Member

kunga commented Feb 27, 2020

Seems it does not work well, due to dotnet/aspnetcore#5914 (comment).

2020-02-27 11:24:58,449 INFO  [T-7d007fb392e043ca8da65c45bf6e7c82] [ConnectionId:0HLTR9MTOBJMT] [RequestPath:/_status/ping RequestId:0HLTR9MTOBJMT:00000002, SpanId:|6870a69c-497fbdc0b2b33779., TraceId:6870a69c-497fbdc0b2b33779, ParentId:] [d808292c] Received request 'GET /_status/ping' from 'KE.Cloud_Kontur.Snitch.ReplicasChecker.houston' at '::ffff:10.217.8.194:62186' with timeout = 3 seconds.

@kunga kunga closed this Feb 27, 2020
@koheatel koheatel deleted the tracing-trace-identifier branch February 27, 2020 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants