This repository has been archived by the owner on Sep 27, 2021. It is now read-only.
Piece wize basebead #460
Merged
Piece wize basebead #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leId in lammpsdatareader.cc
JensWehner
reviewed
Nov 24, 2019
include/votca/csg/basebead.h
Outdated
| molecule_item_(nullptr), | ||
| mass_(0.0), | ||
| bead_position_set_(false){}; | ||
| BaseBead() : topology_item_(nullptr), mass_(0.0), bead_position_set_(false){}; |
There was a problem hiding this comment.
you can initialize them below in th elist
There was a problem hiding this comment.
What do you mean?
There was a problem hiding this comment.
I would set the values of these things not in the constructor but when they are declared in the private section of the class.
|
|
Requires that votca/votca#235 is merged. |
|
This one needs to be merged next, @JensWehner please review! |
Codecov Report
@@ Coverage Diff @@
## master #460 +/- ##
=======================================
+ Coverage 61% 61% +<.1%
=======================================
Files 129 128 -1
Lines 6298 6299 +1
=======================================
+ Hits 3845 3846 +1
Misses 2453 2453
Continue to review full report at Codecov.
|
JensWehner
suggested changes
Dec 9, 2019
include/votca/csg/basebead.h
Outdated
| molecule_item_(nullptr), | ||
| mass_(0.0), | ||
| bead_position_set_(false){}; | ||
| BaseBead() : topology_item_(nullptr), mass_(0.0), bead_position_set_(false){}; |
…to piece-wize-basebead
JensWehner
suggested changes
Dec 9, 2019
|
@JensWehner they have been, which ones are you referring too? |
JensWehner
approved these changes
Dec 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating base bead from issue https://github.com/votca/csg/pull/381/files: