Skip to content
This repository has been archived by the owner on Sep 27, 2021. It is now read-only.

fix pos scaling (ang2nm) in lammps data reader #697

Merged
merged 2 commits into from
Jul 8, 2021
Merged

fix pos scaling (ang2nm) in lammps data reader #697

merged 2 commits into from
Jul 8, 2021

Conversation

junghans
Copy link
Member

@junghans junghans commented Jul 8, 2021

@junghans junghans changed the base branch from master to stable July 8, 2021 16:35
@junghans junghans force-pushed the stable_fix_data_reader_scaling branch from affe465 to 0d53e14 Compare July 8, 2021 16:36
@junghans junghans force-pushed the stable_fix_data_reader_scaling branch from 0d53e14 to 9e62853 Compare July 8, 2021 16:36
JensWehner
JensWehner approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@JensWehner JensWehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with that,
the problem to some extend still is that LAMMPS is unit agnostic to some extend, so it is really hard to tell which units it is actually using in the computation.

@JensWehner
Copy link
Member

@votca-bot format

@junghans
Copy link
Member Author

junghans commented Jul 8, 2021

I am okay with that,
the problem to some extend still is that LAMMPS is unit agnostic to some extend, so it is really hard to tell which units it is actually using in the computation.

True, but be scale the box size in the same reader!

@junghans junghans merged commit 77b8a0b into stable Jul 8, 2021
@junghans junghans deleted the stable_fix_data_reader_scaling branch July 8, 2021 21:05
votca-bot added a commit to votca/votca that referenced this pull request Jul 8, 2021
@votca-bot
Update csg submodule (votca/csg#697)
da6aec4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JensWehner JensWehner JensWehner approved these changes

@JoshuaSBrown JoshuaSBrown Awaiting requested review from JoshuaSBrown

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@junghans @JensWehner