This repository has been archived by the owner on May 26, 2021. It is now read-only.
fixes for -Wextra -Wpedantic -Wshadow -Wconversion #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junghans
force-pushed
the
more_warnings
branch
from
5977e4e
to
ca38c12
Compare
JensWehner
reviewed
Oct 24, 2019
| @@ -209,7 +209,7 @@ void CsgFluctuations::EvalConfiguration(Topology *conf, | |||
| } | |||
| } | |||
| if (r > _rmin && r < _rmax) { | |||
| rbin = (int)_nbins * (double)((r - _rmin) / (_rmax - _rmin)); | |||
There was a problem hiding this comment.
looks a lot like a histogram..hmm.
There was a problem hiding this comment.
True, do you want to refactor?
JensWehner
approved these changes
Oct 24, 2019
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
========================================
+ Coverage 22.1% 22.4% +0.3%
========================================
Files 10 10
Lines 953 938 -15
========================================
Hits 211 211
+ Misses 742 727 -15
Continue to review full report at Codecov.
|
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of votca/votca#212