Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libint2: disable some warnings for gcc-13 #1086

Closed
wants to merge 1 commit into from
Closed

Conversation

junghans
Copy link
Member

For #1084

baumeier
baumeier previously approved these changes Sep 21, 2023
@junghans
Copy link
Member Author

Oh no, I was wrong libint is included in more places.....

git grep include.*libint
xtp/include/votca/xtp/aobasis.h:#include <libint2/shell.h>
xtp/include/votca/xtp/aoshell.h:// include libint last otherwise it overrides eigen
xtp/include/votca/xtp/aoshell.h:#include <libint2/shell.h>
xtp/src/libxtp/aomatrices/aoecp.cc:#include <libint2/solidharmonics.h>
xtp/src/libxtp/aomatrices/aotransform.cc:#include "libint2/solidharmonics.h"
xtp/src/libxtp/libint2_calls.cc:// include libint last otherwise it overrides eigen
xtp/src/libxtp/libint2_calls.cc:#include "votca/xtp/make_libint_work.h"
xtp/src/libxtp/libint2_calls.cc:#include <libint2.hpp>
xtp/src/libxtp/libint2_calls.cc:#include <libint2/statics_definition.h>
xtp/src/libxtp/parallelxjobcalc.cc:#include <libint2/initialize.h>
xtp/src/libxtp/qmcalculator.cc:#include <libint2/initialize.h>
xtp/src/libxtp/qmtool.cc:#include <libint2/initialize.h>
xtp/src/tests/test_DeltaQ_filter.cc:#include <libint2/initialize.h>
xtp/src/tests/test_activedensitymatrix.cc:#include <libint2/initialize.h>
xtp/src/tests/test_activedftengine.cc:#include <libint2/initialize.h>
xtp/src/tests/test_aobasis.cc:#include <libint2/initialize.h>
xtp/src/tests/test_aomatrix.cc:#include <libint2/initialize.h>
xtp/src/tests/test_aomatrix3d.cc:#include <libint2/initialize.h>
xtp/src/tests/test_aopotential.cc:#include <libint2/initialize.h>
xtp/src/tests/test_aoshell.cc:#include <libint2/initialize.h>
xtp/src/tests/test_aotransform.cc:#include <libint2/initialize.h>
xtp/src/tests/test_bse.cc:#include <libint2/initialize.h>
xtp/src/tests/test_bse_operator.cc:#include <libint2/initialize.h>
xtp/src/tests/test_bsecoupling.cc:#include <libint2/initialize.h>
xtp/src/tests/test_convergenceacc.cc:#include <libint2/initialize.h>
xtp/src/tests/test_cubefile_writer.cc:#include <libint2/initialize.h>
xtp/src/tests/test_density_filter.cc:#include <libint2/initialize.h>
xtp/src/tests/test_densityintegration.cc:#include <libint2/initialize.h>
xtp/src/tests/test_dftcoupling.cc:#include <libint2/initialize.h>
xtp/src/tests/test_dftengine.cc:#include <libint2/initialize.h>
xtp/src/tests/test_diabatization.cc:#include <libint2/initialize.h>
xtp/src/tests/test_ecpaobasis.cc:#include <libint2/initialize.h>
xtp/src/tests/test_eris.cc:#include <libint2/initialize.h>
xtp/src/tests/test_espfit.cc:#include <libint2/initialize.h>
xtp/src/tests/test_gaussianwriter.cc:#include <libint2/initialize.h>
xtp/src/tests/test_gw.cc:#include <libint2/initialize.h>
xtp/src/tests/test_hdf5.cc:#include <libint2/initialize.h>
xtp/src/tests/test_localisation_filter.cc:#include <libint2/initialize.h>
xtp/src/tests/test_molden.cc:#include <libint2/initialize.h>
xtp/src/tests/test_orbitals.cc:#include <libint2/initialize.h>
xtp/src/tests/test_orbreorder.cc:#include <libint2/initialize.h>
xtp/src/tests/test_orca.cc:#include <libint2/initialize.h>
xtp/src/tests/test_oscillatorstrength_filter.cc:#include <libint2/initialize.h>
xtp/src/tests/test_overlap_filter.cc:#include <libint2/initialize.h>
xtp/src/tests/test_pmlocalization.cc:#include <libint2/initialize.h>
xtp/src/tests/test_populationanalysis.cc:#include <libint2/initialize.h>
xtp/src/tests/test_ppm.cc:#include <libint2/initialize.h>
xtp/src/tests/test_radial_euler_maclaurin_rule.cc:#include <libint2/initialize.h>
xtp/src/tests/test_regular_grid.cc:#include <libint2/initialize.h>
xtp/src/tests/test_rpa.cc:#include <libint2/initialize.h>
xtp/src/tests/test_rpa_h2p.cc:#include <libint2/initialize.h>
xtp/src/tests/test_sigma_cda.cc:#include <libint2/initialize.h>
xtp/src/tests/test_sigma_exact.cc:#include <libint2/initialize.h>
xtp/src/tests/test_sigma_ppm.cc:#include <libint2/initialize.h>
xtp/src/tests/test_sphere_lebedev_rule.cc:#include <libint2/initialize.h>
xtp/src/tests/test_statetracker.cc:#include <libint2/initialize.h>
xtp/src/tests/test_threecenter_dft.cc:#include <libint2/initialize.h>
xtp/src/tests/test_threecenter_gwbse.cc:#include <libint2/initialize.h>
xtp/src/tests/test_transition_densities.cc:#include <libint2/initialize.h>
xtp/src/tests/test_truncdftengine.cc:#include <libint2/initialize.h>
xtp/src/tests/test_vxc_grid.cc:#include <libint2/initialize.h>
xtp/src/tests/test_vxc_potential.cc:#include <libint2/initialize.h>

so we might need to wrap this into a header like we did for Eigen (see tools/include/votca/tools/eigen.h).

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +7.0% 🎉

Comparison is base (68cb512) 0.0% compared to head (6f37676) 7.0%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1086     +/-   ##
========================================
+ Coverage        0    7.0%   +7.0%     
========================================
  Files           0       4      +4     
  Lines           0     683    +683     
========================================
+ Hits            0      48     +48     
- Misses          0     635    +635     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@baumeier
Copy link
Member

Ugh, do we then have to add all the specific includes to this wrapper? Because some only need <libint2/initialize.h> but others more.

@junghans
Copy link
Member Author

Yeah, we have to overwrite it everywhere. We will already have xtp/include/votca/xtp/make_libint_work.h so we could put the all the libint2 includes in there.

@junghans
Copy link
Member Author

junghans commented Oct 1, 2023

@baumeier do you want to take a crack at this?

@junghans
Copy link
Member Author

We solved that differently in #1088.

@junghans junghans closed this Nov 15, 2023
@junghans junghans deleted the libint_warnings branch November 15, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants