Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

fix build on older gcc #577

Merged
merged 3 commits into from Oct 25, 2020
Merged

fix build on older gcc #577

merged 3 commits into from Oct 25, 2020

Conversation

junghans
Copy link
Member

@junghans
Copy link
Member Author

@votca-bot changelog: fix build on Ubuntu 16.04

@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #577 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #577   +/-   ##
======================================
  Coverage    57.3%   57.3%           
======================================
  Files         313     313           
  Lines       32388   32388           
======================================
  Hits        18566   18566           
  Misses      13822   13822           
Impacted Files Coverage Δ
include/votca/xtp/molden.h 100.0% <ø> (ø)
include/votca/xtp/orbreorder.h 100.0% <ø> (ø)
src/libxtp/qmpackages/orca.h 100.0% <ø> (ø)
src/libxtp/qmpackages/xtpdft.h 0.0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39fdfe6...96001ef. Read the comment docs.

Copy link
Member

@JensWehner JensWehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I am not sure if we still support gcc 5.4 but I do not mind.

Thanks for the fix

@JensWehner JensWehner merged commit a6cccd5 into master Oct 25, 2020
@JensWehner JensWehner deleted the sandipan_fix branch October 25, 2020 13:38
votca-bot added a commit to votca/votca that referenced this pull request Oct 25, 2020
@sandipan84
Copy link

I verify that I have made the above changes (mentioned by Christoph) to the files-- molden.h, orbreorder.h, orca.h and xtpdft.h for installing VOTCA in my Ubuntu 16.04 desktop.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants