Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pagination 10 and hotfix getVotesForDelegate #41

Merged
merged 1 commit into from Jan 2, 2024
Merged

add pagination 10 and hotfix getVotesForDelegate #41

merged 1 commit into from Jan 2, 2024

Conversation

ferrodri
Copy link
Collaborator

@ferrodri ferrodri commented Dec 19, 2023 •
edited

  • paginate every 10 past votes
  • hotfix getVotesForDelegate

@linear Linear
Copy link

linear bot commented Dec 19, 2023

AGORA-1400 Fix the Pagination of votes on the delegate page

@vercel Vercel
Copy link

vercel bot commented Dec 19, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agora-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 1:37pm

@ferrodri ferrodri requested a review from kent December 19, 2023 13:35
@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Dec 19, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

kent
kent previously requested changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@kent kent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Delegate view, PastVotes is not working though with this pagination. Can you confirm and test again?

@ferrodri
Copy link
Collaborator Author

Hi @kent I made this loom video where I added a 2s delay to the infinite scroll so you could see it better, this is what you meant right? https://www.loom.com/share/0a0fd54fa0c847a0905cee3371e505aa?sid=11e1a376-03c3-48dc-a1cc-94c606b92044

@stepandel stepandel self-requested a review January 2, 2024 20:01
stepandel
stepandel approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@stepandel stepandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stepandel stepandel self-requested a review January 2, 2024 20:02
@stepandel stepandel dismissed kent’s stale review January 2, 2024 20:03

taking over Kent's review

@stepandel stepandel merged commit a68c0ba into main Jan 2, 2024
2 checks passed
@stepandel stepandel deleted the frodriguezhervias/agora-1400-fix-the-pagination-of-votes-on-the-delegate-page branch January 2, 2024 20:04
@stepandel stepandel removed their request for review January 2, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepandel stepandel stepandel approved these changes

@kent kent kent left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ferrodri @kent @stepandel