Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wojeth/agora-1458 Draw gray line even without any votes #70

Merged
merged 1 commit into from Jan 17, 2024
Merged

wojeth/agora-1458 Draw gray line even without any votes #70

merged 1 commit into from Jan 17, 2024

Conversation

wojtekwtf
Copy link
Collaborator

Screenshot 2024-01-17 at 16 02 25

@linear Linear
Copy link

linear bot commented Jan 17, 2024

AGORA-1458 0 - 0 votes should display a gray-300 bar instead of not showing a bar at all

@vercel Vercel
Copy link

vercel bot commented Jan 17, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agora-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 3:06pm

@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Jan 17, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

This is an automated message generated by Sweep AI.

kent
kent approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@kent kent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kent kent merged commit 1bd728b into main Jan 17, 2024
2 checks passed
@mcgingras mcgingras deleted the wojeth/agora-1458-0-0-votes-should-display-a-gray-300-bar-instead-of-not branch May 2, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kent kent kent approved these changes

@yitongzhang yitongzhang Awaiting requested review from yitongzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wojtekwtf @kent