Reported batch results and discrepancies in audit report #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbernhard
approved these changes
Jul 6, 2021
server/api/reports.py
Outdated
| macro.compute_error( | ||
| {contest.name: reported_results}, | ||
| {contest.name: audit_results}, | ||
| # Construct the contest object by hand instead of using |
There was a problem hiding this comment.
Would it make more sense to add another from_db_contest function or add a flag to the existing one that does this? Are we likely to have to do this again?
There was a problem hiding this comment.
After reading this comment, I ended up figuring out another way to do this that just uses from_db_contest instead
I think in batch comparison we have to rely on the auditors to count not found ballots for the loser, since they enter a count for the entire batch. |
|
doh, that's right. My bad! |
jonahkagan
force-pushed
the
batch-tallies-in-report
branch
from
c3dcf54
to
35370e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: #1222
Reworks
macro.compute_errorto return aBatchErrordict so that we can return both the raw error in votes and the weighted error (mirroring what we do insupersimplefor ballot comparison). Then adds the raw error to the audit report, along with the reported results from the batch tallies file. We count and report negative errors as 0, while batches with no error are counted as 0 but reported as blank.