Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md - Make main readme file about JS SDK #264

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

p-zielinski
Copy link
Contributor

@sedzia suggested that almost noone is using react widgets, and we shall make our main readme more about JS SDK


You can find TS example in [examples/sdk/with-nodejs-typescript](/examples/sdk/with-nodejs-typescript).
You can find TS example in [examples/with-nodejs-typescript](/examples/with-nodejs).
Copy link
Contributor

@jkaliszuk jkaliszuk Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is not working.


Structure / typing for error returned from Voucherify API can be seen here:
- [VoucherifyError class](/packages/sdk/src/VoucherifyError.ts)
- [VoucherifyError class](src/VoucherifyError.ts)
Copy link
Contributor

@jkaliszuk jkaliszuk Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is not working.

@@ -148,9 +1781,9 @@ Read more about how to Contribute to Voucherify JS SDK by visiting [CONTRIBUTING

# <a name="changelog"></a>🗄️ Changelog

Voucherify React Widget CHANGELOG can be found [here](/packages/react-widget/CHANGELOG.md).
Visit [CHANGELOG](./CHANGELOG.md) to learn more about new changes.
Copy link
Contributor

@jkaliszuk jkaliszuk Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is not working.


If you wish to see code examples for server-side error handling, you can check it here:
- [Error handling for Node.JS example without TypeScript](/examples/sdk/with-nodejs/server-error-handling.js)
- [Error handling for Node.JS example with TypeScript](/examples/sdk//with-nodejs-typescript/server-error-handling.ts)
Copy link
Contributor

@jkaliszuk jkaliszuk Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/examples/sdk//should rather be single slash but works anyway.


# <a name="migration"></a>↔️ Migration

Check out [MIGRATION GUIDE](/packages/sdk/MIGRATION.md) to learn more about switching to the newest Voucherify JS SDK.
Check our [MIGRATION GUIDE](./MIGRATION.md) to learn more about switching to our newest SDK.
Copy link
Contributor

@jkaliszuk jkaliszuk Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants