New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve order of nested asynchronous teardowns #223
Labels
Comments
Here's example code that shows the problem: |
This was referenced Nov 22, 2014
Closed
indexzero
added a commit
that referenced
this issue
Nov 22, 2014
…urable `2000ms` timeout. Fixes #223.
This works in 1.x, so I'm closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The teardown for a context should only fire after the teardown of its contained contexts have finished.
I use teardowns for testing persistence code. The outer context makes the database connection and its teardown disconnects; inner contexts create temporary database structures and their teardowns delete the structures.
(And, yes, I'm aware that it's possible to just leave those structures in place, or what have you. But I think that good unit tests clean up after themselves.)
We've got good support for letting sub-contexts finish most of their work before teardowns happen; let's finish the job.
The text was updated successfully, but these errors were encountered: