Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convention for naming spec files? #37

Closed
assaf opened this issue Dec 10, 2010 · 5 comments
Closed

Convention for naming spec files? #37

assaf opened this issue Dec 10, 2010 · 5 comments

Comments

@assaf
Copy link

assaf commented Dec 10, 2010

vows --watch assumes a convention for naming spec files, but generally it loads all the files it finds in spec/test, not just those with test-/spec- in their name.

If it filtered and only loaded files that follow the convention (when not giving explicit file names), it would be easier to work with vows and have unrelated JavaScript files in the spec directory.

My test suite includes JS files that should not be required (I load them separately), but are part of the data used for testing.

@cloudhead
Copy link

Fixing this.

@martypdx
Copy link

Any chance you can clearly document how the watch is intended to work? I have not been able to set it up in any useful manner.

@indexzero
Copy link

@cloudhead Is this fixed?

@silkentrance
Copy link

Watch mode looks out for either

coffee-script+javascript: specFileExt = /.(-|_).(js|coffee)$/;
or just javascript: specFileExt = /.(-|_).js$/;

Besides that, in bin/vows 381ff testing the specFileExt against file will always result in all tests being run with #337 being in place, heck 👯 - I will look into this ASAP.

AFAIC #337 will not break the existing behavior.

@mmhansen
Copy link

Looks like vows is picking up all files ending in .coffee or .js in the test or spec dir.
line 218

I'll put command line option for test file pattern in the feature list.
Everyone else has the ability to do this, so we should as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants