-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building on Xcode 12 #30
Comments
@VTCoco could you please upgrade voxeet-uxkit-cordova project for compatibility with XCode 12 ? |
Hello @mattyg, you were on a good track but you forgot to also bump the VoxeetSDK version. My carthage.sh script looks like:
|
Thanks @VTCoco, but the build is still failing with the same error on 1.3.33. Have you been able to successfully install the plugin in an example cordova app? |
With these steps I got my sample running:
The last step should fail because it can't use carthage with Xcode 12 on SDWebImageMapKit or VoxeetUXKit:
Then launch the local carthage script:
|
@VTCoco Huh, I'm not sure what's different about my system. I tried on Xcode 12.0.1 and downgraded to 12.0 and am still getting the same result. I'm following the same steps, and the ./carthage.sh command output still ends with:
And the xcodebuild log still ends with:
|
How is that suppose to run in a CI? The plugin script is still failing |
Waiting for an official solution from Carthage maybe the current "best" way is to modify cordova script to use the custom carthage.sh (#30 (comment))? |
I think this is a valid solution. Add the carthage.sh to the repo and call it. |
@Tallyb Is it actually building for you with the carthage.sh script? |
It's building and working properly now with the new release 1.3.35 running the 3.x sdk. Thanks so much for your help! |
Well - you would except upgrading the sdk to a major version would at least be a minor version for this plugin, no? |
Hello, yes we published the v1.3.35 with your advices to integrate the Carthage script into the Cordova build, thank you for your help. |
@VTCoco - I think it will work best if you simply embed the built framework in the code and not rely on local carthage. That can surely remove many problems of the build, and any new sdk requires a new release whatsoever. |
Do you want our .framework directly been published into github? (this is a bad idea) However if you want to get our .framework from somewhere else than Carthage (which doesn't officially support Xcode 12 for now as a reminder...) you can grab them from our S3 links available here: https://github.com/voxeet/voxeet-sdk-ios/blob/master/VoxeetSDK.json |
well, wikitude cordova plugins, for instance, place the FW inside the repo. Anyway, having those links is useful. thank you. |
I saw that voxeet-uxkit-ios was just updated 1.3.6 to support building with Carthage on Xcode 12. I forked this plugin to use the updated voxeet-uxkit-ios, but I'm still unable to build it.
After adding the plugin to cordova, and it failing, I run the following (where carthage.sh is the script noted in this comment
The xcodebuild log ends with the following:
The text was updated successfully, but these errors were encountered: