Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setAudio3DEnabled and setTelecomMode #20

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add setAudio3DEnabled and setTelecomMode #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b0ecab
Merge pull request #2 from voxeet/beta/0.2.6
FabienLavocat Feb 23, 2021
c1fec2e
Add setAudio3DEnabled and setTelecomMode
FabienLavocat Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions android/src/main/java/com/voxeet/RNVoxeetConferencekitModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,11 +426,21 @@ public void sendBroadcastMessage(String message, final Promise promise) {
.error(promise::reject);
}

@ReactMethod
public void setAudio3DEnabled(boolean enabled) {
VoxeetSDK.mediaDevice().setAudio3DEnabled(enabled);
}

@ReactMethod
public void isAudio3DEnabled(Promise promise) {
promise.resolve(VoxeetSDK.mediaDevice().isAudio3DEnabled());
}

@ReactMethod
public void setTelecomMode(boolean enabled) {
VoxeetSDK.conference().ConferenceConfigurations.telecomMode = enabled;
}

@ReactMethod
public void isTelecomMode(Promise promise) {
promise.resolve(VoxeetSDK.conference().ConferenceConfigurations.telecomMode);
Expand Down
12 changes: 10 additions & 2 deletions dist/VoxeetSDK.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,21 @@ export default class _VoxeetSDK {
*/
sendBroadcastMessage(message: string): Promise<boolean>;
/**
* Is telecom mode enabled.
* Sets the audio 3D.
*/
isTelecomMode(): Promise<boolean>;
setAudio3DEnabled(enable: boolean): void;
/**
* Is audio 3D enabled.
*/
isAudio3DEnabled(): Promise<boolean>;
/**
* Sets the telecom mode.
*/
setTelecomMode(enable: boolean): void;
/**
* Is telecom mode enabled.
*/
isTelecomMode(): Promise<boolean>;
/**
* Sets if you want the UXKit to appear maximized or not.
* @param maximized True to have the UXKit to appear maximized
Expand Down
18 changes: 15 additions & 3 deletions dist/VoxeetSDK.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/VoxeetSDK.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 14 additions & 0 deletions ios/RNVoxeetConferencekit/RNVoxeetConferencekit.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,12 +250,26 @@ @implementation RNVoxeetConferencekit
});
}

RCT_EXPORT_METHOD(setAudio3DEnabled:(BOOL)enable)
{
dispatch_async(dispatch_get_main_queue(), ^{
VoxeetSDK.shared.conference.audio3D = enable;
});
}

RCT_EXPORT_METHOD(isAudio3DEnabled:(RCTPromiseResolveBlock)resolve
ejecter:(RCTPromiseRejectBlock)reject)
{
resolve([NSNumber numberWithBool:VoxeetSDK.shared.conference.audio3D]);
}

RCT_EXPORT_METHOD(setTelecomMode:(BOOL)enable)
{
dispatch_async(dispatch_get_main_queue(), ^{
VoxeetUXKit.shared.telecom = enable;
});
}

RCT_EXPORT_METHOD(isTelecomMode:(RCTPromiseResolveBlock)resolve
ejecter:(RCTPromiseRejectBlock)reject)
{
Expand Down
20 changes: 17 additions & 3 deletions lib/VoxeetSDK.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,10 @@ export default class _VoxeetSDK {
}

/**
* Is telecom mode enabled.
* Sets the audio 3D.
*/
isTelecomMode(): Promise<boolean> {
return RNVoxeetConferencekit.isTelecomMode();
setAudio3DEnabled(enable: boolean): void {
RNVoxeetConferencekit.setAudio3DEnabled(enable);
}

/**
Expand All @@ -118,6 +118,20 @@ export default class _VoxeetSDK {
return RNVoxeetConferencekit.isAudio3DEnabled();
}

/**
* Sets the telecom mode.
*/
setTelecomMode(enable: boolean): void {
RNVoxeetConferencekit.setTelecomMode(enable);
}

/**
* Is telecom mode enabled.
*/
isTelecomMode(): Promise<boolean> {
return RNVoxeetConferencekit.isTelecomMode();
}

/**
* Sets if you want the UXKit to appear maximized or not.
* @param maximized True to have the UXKit to appear maximized
Expand Down