Formalizing Featurizer interfaces #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brimoor
changed the title
mattphotonman
approved these changes
Jun 12, 2019
eta/core/features.py
Outdated
| '''Configuration settings for an ORBFeaturizer.''' | ||
| def get_feature_paths(self): | ||
| '''Returns a list of absolute paths to the features on disk.''' | ||
| return etau.list_files(self.backing_dir, abs_paths=True) |
There was a problem hiding this comment.
What if there are other files in the backing directory besides the feature directories?
There was a problem hiding this comment.
Good point. I added in a basic .endswith(".npz") filter.
As a general principle, we should avoid putting more than one type of thing in directories that contain sequences like %06.<ext>. For example, eta.core.utils.parse_dir_pattern is used heavily throughout the pipeline system, and it will get confused if there are multiple types of sequences in there.
|
@mattphotonman thanks for the careful review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #235.
Change log
ImageFeaturizer,VideoFramesFeaturizer, andVideoFeaturizerinterfaces toeta.core.featuresthat encapsulate the various image/tensor/video contracts that featurizers can useeta.core.features.VideoFramesFeaturizerwith a neweta.core.features.CachingVideoFeaturizerclass.CachingVideoFeaturizerhas the same basic functionality as the formerVideoFramesFeaturizerclass with the addition of improved functionality for accessing the features on disk. Also formalizes theBackingManagerinterfaceImageFeaturizer,VideoFramesFeaturizer, andVideoFeaturizerinterfacesexamples/demo_embed_vgg16to use the newCachingVideoFeaturizerclass