Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements with a vague description #435

Merged
merged 5 commits into from
Feb 20, 2020
Merged

Small improvements with a vague description #435

merged 5 commits into from
Feb 20, 2020

Conversation

tylerganter
Copy link
Contributor

@tylerganter tylerganter commented Feb 20, 2020 •
edited
Loading

  • Sorting categorical schema categories such that the schema JSON is predictable when serialized
  • exposing read/write labels for LabeledDataset
  • verbose when finding duplicates (this takes a long time generally)

@tylerganter tylerganter changed the title verbose find dups Small improvements with a vague description Feb 20, 2020
@tylerganter tylerganter requested a review from a team February 20, 2020 22:03
@tylerganter tylerganter self-assigned this Feb 20, 2020
@tylerganter tylerganter marked this pull request as ready for review February 20, 2020 22:03
@tylerganter tylerganter added the enhancement Code enhancement label Feb 20, 2020
benjaminpkane
benjaminpkane approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

brimoor
brimoor approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small comment for ya

eta/core/utils.py Outdated
@@ -2257,26 +2257,34 @@ def remove_none_values(d):
return {k: v for k, v in iteritems(d) if v is not None}


def find_duplicate_files(path_list):
def find_duplicate_files(path_list, verbose=True):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typical convention would be to set verbose=False by default, to avoid spam

@tylerganter tylerganter merged commit 33ff066 into develop Feb 20, 2020
@tylerganter tylerganter deleted the small-changes2dev branch February 20, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminpkane benjaminpkane benjaminpkane approved these changes

@brimoor brimoor brimoor approved these changes

Assignees

@tylerganter tylerganter

Labels
enhancement Code enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tylerganter @benjaminpkane @brimoor