Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Limit integer label filter sliders to integers #584

Closed
brimoor opened this issue Oct 7, 2020 · 0 comments · Fixed by #963
Closed

[FR] Limit integer label filter sliders to integers #584

brimoor opened this issue Oct 7, 2020 · 0 comments · Fixed by #963
Labels
app Issues related to App features enhancement Code enhancement

Comments

@brimoor
Copy link
Contributor

brimoor commented Oct 7, 2020

Here's a dataset with some scalar values on its samples that have type IntField:

Name:           quickstart
Media type      image
Num samples:    200
Persistent:     False
Info:           {}
Tags:           ['validation']
Sample fields:
    media_type:   fiftyone.core.fields.StringField
    filepath:     fiftyone.core.fields.StringField
    tags:         fiftyone.core.fields.ListField(fiftyone.core.fields.StringField)
    metadata:     fiftyone.core.fields.EmbeddedDocumentField(fiftyone.core.metadata.Metadata)
    ground_truth: fiftyone.core.fields.EmbeddedDocumentField(fiftyone.core.labels.Detections)
    uniqueness:   fiftyone.core.fields.FloatField
    predictions:  fiftyone.core.fields.EmbeddedDocumentField(fiftyone.core.labels.Detections)
    tp_iou_0_75:  fiftyone.core.fields.IntField
    fp_iou_0_75:  fiftyone.core.fields.IntField
    fn_iou_0_75:  fiftyone.core.fields.IntField

It would be desirable if the label filter in the App respected the int data type and locked the slider into int values, rather than allowing/showing [0.00 [34.92, 81.48] 97.00] in the App

Screen Shot 2020-10-07 at 2 01 12 PM

@brimoor brimoor added enhancement Code enhancement app Issues related to App features labels Oct 7, 2020
@lethosor lethosor changed the title [FR] Respect data type for numeric label filter sliders [FR] limit integer label filter sliders to integers Oct 8, 2020
@brimoor brimoor changed the title [FR] limit integer label filter sliders to integers [FR] Limit integer label filter sliders to integers Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Issues related to App features enhancement Code enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant