Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add a utils library for generating plots of-interest for native FiftyOne data types #784

Closed
brimoor opened this issue Jan 14, 2021 · 2 comments
Labels
core Issues related to Core features feature Work on a feature request

Comments

@brimoor
Copy link
Contributor

brimoor commented Jan 14, 2021

From #777 (comment):

It would be nice to expose a utils module that contains methods for things like my plot_hist() code in the description of the PR above that can be used to generate plots of our Aggregations.

Similarly, we could provide utils for generating confusion matrix plots, PR curves, and other items related to evaluation. All with native support for FiftyOne data types as input.

Now that FiftyOne works natively in notebooks, leveraging matplotlib for these kind of outputs is at 50% towards native in-App plots (same information, minus the interactively), while also being significantly easier to implement.

@brimoor brimoor added feature Work on a feature request core Issues related to Core features needs discussion An issue that needs more discussion before action is taken labels Jan 14, 2021
@benjaminpkane
Copy link
Contributor

benjaminpkane commented Jan 18, 2021

I think we'll get the best flexibility out of plotting if we add the option to output Aggregation results as Pandas Dataframes. We could make Dataframes the default, even.

@brimoor
Copy link
Contributor Author

brimoor commented Feb 22, 2021

This was largely addressed in v0.7.3, where a convention was established that things like evaluation results come in an EvaluationResults class, which provides methods for generating various supported plots, etc.

Note that AggregationResult was removed in favor of returning the raw aggregation results, which means that FiftyOne is shirking responsibility for things like plot_hist() (the user has the raw data, so they can do it themselves).

@brimoor brimoor closed this as completed Feb 22, 2021
@brimoor brimoor removed the needs discussion An issue that needs more discussion before action is taken label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues related to Core features feature Work on a feature request
Projects
None yet
Development

No branches or pull requests

3 participants