Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast sample parsing #117

Merged
merged 24 commits into from Jun 1, 2020
Merged

Fast sample parsing #117

merged 24 commits into from Jun 1, 2020

Conversation

tylerganter
Copy link
Contributor

Using a much lighter-weight class for backing docs of samples that are not in a dataset (completely without mongoengine). New class NoDatasetSample is just backed by an OrderedDict and is fast to create, convert to dict, etc.

  • ODMSample and ODMDatasetSample --> ODMSample
  • ODMNoDatasetSample --> NoDatasetSample

@tylerganter tylerganter added the enhancement Code enhancement label May 29, 2020
@tylerganter tylerganter requested a review from a team May 29, 2020 22:35
@tylerganter tylerganter self-assigned this May 29, 2020
@tylerganter tylerganter merged commit 63c68e6 into develop Jun 1, 2020
@tylerganter tylerganter deleted the fast-sample-parsing branch June 1, 2020 15:02
@brimoor brimoor mentioned this pull request Jun 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminpkane benjaminpkane benjaminpkane approved these changes

Assignees

@tylerganter tylerganter

Labels
enhancement Code enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tylerganter @benjaminpkane