Update PyTorch Lightning Flash integration #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehofesmann
added
documentation
ehofesmann
changed the title
brimoor
requested changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1482
This PR updates the integration with pytorch lightning flash to work with the updates from the past two versions that resulted in breaking changes for the previous implementation. The integration now works with flash versions >= 0.7.0.
Now, the tasks of classification, detection, segmentation, and embedding generation for images and classification for video work again. Additionally, the
dataset.apply_model(flash_model)syntax can be used again.There were various changes made in lightning flash, the most relevant being:
model.predict()no longer being supported, onlytrainer.predict(model, datamodule)data_pipelinestored in the modeloutputand their parameters changedThis PR also adds intensive tests copying all examples in our integration documentation to allow them to be tested more easily and regularly to track future chagnes.