Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenLABEL importer updates #1812

Merged
merged 17 commits into from Jun 2, 2022
Merged

OpenLABEL importer updates #1812

merged 17 commits into from Jun 2, 2022

Conversation

ehofesmann
Copy link
Member

This PR revamps the OpenLABEL importers to be much more flexible with regards to loading attributes and adds the ability to load keypoint pose data and correspond them to a given skeleton.

Specifically, it adds the skeleton and skeleton_key arguments to the OpenLABEL importers that let you provide a KeypointSkeleton used to load keypoints of the skeleton in the correct order and a skeleton_key that provides the key into the OpenLABEL annotation dictionary to the label of each point that matches the labels in the skeleton.

dataset = fo.Dataset.from_dir(
    data_path=self.images_dir,
    labels_path=labels_path,
    dataset_type=fo.types.OpenLABELImageDataset,
    label_types="keypoints",
    skeleton_key=skeleton_key,
    skeleton=skeleton,
)

A new test was added for these keypoint poses that can be run to test this PR.

@ehofesmann ehofesmann added the enhancement Code enhancement label Jun 1, 2022
@ehofesmann ehofesmann requested a review from a team June 1, 2022 22:44
@ehofesmann ehofesmann self-assigned this Jun 1, 2022
@ehofesmann ehofesmann changed the title OpenLABEL Updates OpenLABEL importer updates Jun 1, 2022
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehofesmann ehofesmann merged commit 1485406 into develop Jun 2, 2022
@ehofesmann ehofesmann deleted the openlabel branch June 2, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants