Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install.rst #2068

Merged

Conversation

GeorgePearse
Copy link
Contributor

What changes are proposed in this pull request?

Resolution of #2067, include quotation marks for

pip install "fiftyone[desktop]"

How is this patch tested? If it is not, please explain why.

Tested by user

Copy link
Member

@findtopher findtopher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is primarily a zsh issue, but testing shows that it works fine in bash so the quotes are probably a good idea.

May need to dig deeper into the docs and make sure that all the commands work with zsh (the OS X standard now) - but the unescaped []s are definitely a problem for zsh.

@brimoor brimoor merged commit f6905e9 into voxel51:develop Sep 7, 2022
@GeorgePearse
Copy link
Contributor Author

Cheers, realised it may be operating system thing as I wrote it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants