Add frontend support for loading overlay masks from disk #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sashankaryal
force-pushed
the
feature/file-segmentation
branch
2 times, most recently
from
c9dcf4c
to
a778d73
Compare
benjaminpkane
approved these changes
Dec 6, 2022
| const LABELS = new Set(VALID_LABEL_TYPES); | ||
| const ALL_VALID_LABELS = new Set(VALID_LABEL_TYPES); | ||
|
|
||
| const LABELS_THAT_CAN_HAVE_OVERLAYS_ON_DISK = new Set([ |
There was a problem hiding this comment.
I would propose naming this something like ARRAY_LABELS and including in @fiftyone/utilities with the other constants for reuse.
| Object.hasOwn(label, overlayField) || | ||
| !Object.hasOwn(label, overlayPathField) | ||
| ) { | ||
| // nothing to be done |
There was a problem hiding this comment.
I would propose removing
Suggested change
| // nothing to be done |
Comment on lines
+172
to
+173
| // convert absolute file path to a URL that we can "fetch" from | ||
| const overlayPngImageUrl = getSampleSrc(label[overlayPathField] as string); |
There was a problem hiding this comment.
Maybe alias or rename getSampleSrc so it is self-explanatory.
Suggested change
| // convert absolute file path to a URL that we can "fetch" from | |
| const overlayPngImageUrl = getSampleSrc(label[overlayPathField] as string); | |
| const overlayPngImageUrl = expandToURL(label[overlayPathField] as string); |
| * Some label types (example: segmentation, heatmap) can have their overlay data stored on-disk, | ||
| * we want to impute the relevant mask property of these labels from what's stored in the disk | ||
| */ | ||
| const imputeOverlayFromPath = async ( |
There was a problem hiding this comment.
Maybe rename to illustrate the comment?
Suggested change
| const imputeOverlayFromPath = async ( | |
| loadArrayLabels |
|
Thanks for the comments, @benjaminpkane, will address them in the next unit of segmentation work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Frontend support for loading overlay masks from disk
How is this patch tested? If it is not, please explain why.
Tested locally.
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
Refer to #2301
What areas of FiftyOne does this PR affect?
fiftyonePython library changes