-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More PyTorch theme fixes #236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the top nav is still not quite right aligned:
And this is more of opinion, but I liked having the home button better than having a FiftyOne
link. Even though I knew what i was looking for it took me a minute to find the FiftyOne
link which isn't as attention grabbing as it ideally could be
Otherwise looks good!
Is that Firefox? Your screenshot is wider than my physical screen, so I suspect there's a wider screen size where the content widens that I didn't handle. |
Looks like the same problem to me in your screen shot. |
No, my intention was to align it to the right side of the content, not the sidebar (which is basically where it was before the theme change), since not all pages have a right sidebar. It's about 50-100px further to the left in your screenshot than mine, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @lethosor!!
Can you squeeze in a couple small changes before you merge?
- Can you increase the font size on the smallest elements like the sidebars, the
Docs > XXXX
links at the top, etc? They're pretty small right now. On https://voxel51.com/docs/fiftyone currently, the main body is 16pt and those other things are either 16pt or 15pt. On this branch, they're all 14pt. I'd try all 16pt, and, if that looks weird, then try 15pt. - If it's easy, can you make the line number sidebars on the code blocks fixed width? On my local build they seem to be variable width and often get too wide. EG
user_guide/using_dataset
for the most apparent example:
I like Alan's goal of aligning with the RHS of the content, not the sidebar. I observe some minor strangeness when adjusting the size of my browser window. There are some transition points when the header jumps 50-100px to the right as it seems Tyler observed |
Addressed comments from #236 (review) - the header positioning only seems to be an issue somewhere between 900px and 1200px wide, and isn't worth delaying other fixes for now |
Closes #230