Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

count exact number of frames with ffprbe -count_frames #2373

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

Rusteam
Copy link
Contributor

@Rusteam Rusteam commented Nov 30, 2022

What changes are proposed in this pull request?

Count exact number of frames in a video.

How is this patch tested? If it is not, please explain why.

added a unit-test to the intensive group.

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

Exact number of frames can be counted with fiftyone.utils.video.exact_frame_count().
This method uses -count_frames argument of ffprobe which decodes the entire video to count the frames and can be very slow.

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks! 🙏

@brimoor brimoor merged commit 2dcf237 into voxel51:develop Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants