Remove none as an option from other value options
#2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanzhenw
changed the title
none as an option from other value options
lanzhenw
force-pushed
the
bugfix/none-filter-handle
branch
from
e78bba4
to
eebef1a
Compare
lanzhenw
changed the title
none as an option from other value optionsnone as an option from other value options
lanzhenw
added a commit
that referenced
this pull request
Dec 7, 2022
jacobmarks
pushed a commit
that referenced
this pull request
Dec 7, 2022
jacobmarks
pushed a commit
that referenced
this pull request
Dec 7, 2022
lanzhenw
added a commit
that referenced
this pull request
Dec 11, 2022
lanzhenw
added a commit
that referenced
this pull request
Dec 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2277
What changes are proposed in this pull request?
None/Null should not be treated equally as the other value options. There will be a separate ticket tracking how to allow user to select the empty value samples.
How is this patch tested? If it is not, please explain why.
(Details)
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?
fiftyonePython library changes