Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

externalize plugin deps #2680

Merged
merged 1 commit into from Feb 23, 2023
Merged

externalize plugin deps #2680

merged 1 commit into from Feb 23, 2023

Conversation

ritch
Copy link
Contributor

@ritch ritch commented Feb 22, 2023

Allow for plugins to load components and utilities from runtime instead of compiling their own, with its own state at runtime. This fixes issues where the fetch function will point to the wrong URL and cuts down on build times for plugins that use components.

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 62.48% // Head: 61.45% // Decreases project coverage by -1.03% ⚠️

Coverage data is based on head (9cd5b87) compared to base (8e0d036).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2680      +/-   ##
===========================================
- Coverage    62.48%   61.45%   -1.03%     
===========================================
  Files          249      249              
  Lines        42432    42475      +43     
  Branches       348      346       -2     
===========================================
- Hits         26512    26102     -410     
- Misses       15920    16373     +453     
Flag Coverage Δ
app 48.63% <100.00%> (-1.42%) ⬇️
python 99.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/packages/plugins/src/index.ts 60.20% <100.00%> (+0.84%) ⬆️
.../packages/spaces/src/components/StyledElements.tsx 89.65% <100.00%> (+0.18%) ⬆️
tests/unittests/view_tests.py 99.85% <100.00%> (+<0.01%) ⬆️
app/packages/looker/src/elements/base.ts 27.45% <0.00%> (-24.51%) ⬇️
app/packages/looker/src/elements/common/options.ts 9.24% <0.00%> (-23.64%) ⬇️
app/packages/looker/src/overlays/base.ts 48.85% <0.00%> (-20.62%) ⬇️
app/packages/utilities/src/Resource/Resource.ts 13.33% <0.00%> (-20.00%) ⬇️
...pp/packages/looker/src/elements/common/controls.ts 15.33% <0.00%> (-17.34%) ⬇️
app/packages/looker/src/elements/image.ts 20.00% <0.00%> (-15.56%) ⬇️
app/packages/utilities/src/errors.ts 13.04% <0.00%> (-14.91%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

app/packages/plugins/src/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritch ritch merged commit 12d1d78 into develop Feb 23, 2023
@ritch ritch deleted the externalize-plugin-deps branch February 23, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants